-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfixes to testnet nov 6 #941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* skip netuid 0 for pending emission accum * comment
* add comment also * chore: fmt * add back delta handling in helpers * track removals in stake delta * handle stake delta in ck swap func * add tests back * add tests for staking back * add back test for ck swap
* respect chk for set weights min stake filter * use for test func * respect chk in set weights call also * add tests back * fix weights min stake tests also
keithtensor
added
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
and removed
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
labels
Nov 7, 2024
gztensor
previously approved these changes
Nov 7, 2024
camfairchild
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to bump the spec
gztensor
added
the
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
label
Nov 7, 2024
gztensor
approved these changes
Nov 7, 2024
camfairchild
approved these changes
Nov 7, 2024
unconst
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #938.
Contains the following PRs to merge into testnet:
Hotfix/skip root for emission accum #933
Hotfix/clear stake delta on drain #934
respect chk for set weights min stake filter #935
use chk for neuron info lite stake #936