Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide #947

Open
wants to merge 1 commit into
base: devnet-ready
Choose a base branch
from
Open

Update contribution guide #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@

## Lifecycle of a Pull Request

1. Individuals wishing to contribute to subtensor should develop their change/feature/fix in a
[Pull Request](https://github.com/opentensor/subtensor/compare) (PR) targeting the `devnet-ready`
branch of the subtensor GitHub repository. It is recommended to start your pull request as a
draft initially until you are ready to have other developers actively look at it. Any
changes to pallet/runtime code should be accompanied by integration and/or unit tests fully
testing all the edge cases of this functionality, if applicable.
![image](docs/img/pr-lifecycle.png)

1. Individuals wishing to contribute to subtensor should develop their change/feature/fix based on
the `devnet-ready` branch and create a [Pull Request](https://github.com/opentensor/subtensor/compare)
(PR) targeting the `devnet-ready` branch of the subtensor GitHub repository. It is recommended
to start your pull request as a draft initially until you are ready to have other developers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to start your pull request as a draft initially until you are ready to have other developers
to start your pull request as a draft until you are ready to have other developers

actively look at it. Any changes to pallet/runtime code should be accompanied by integration
and/or unit tests fully testing all the edge cases of this functionality, if applicable.
2. Once you have finished developing your change/feature/fix and the Rust portion of the CI is
passing for your PR (everything prefixed with "CI"), you should mark your PR as "Ready for
Review" and request review from "Nucleus".
Expand Down
Binary file added docs/img/pr-lifecycle.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading