Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get stake interface in solidity #955

Open
wants to merge 5 commits into
base: devnet-ready
Choose a base branch
from

Conversation

open-junius
Copy link
Contributor

@open-junius open-junius commented Nov 12, 2024

Description

The PR add the stake data access in solidity precompile contract.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius requested a review from unconst as a code owner November 12, 2024 10:24
@open-junius open-junius changed the title get stake interface in solidity [WIP] get stake interface in solidity Nov 12, 2024
@open-junius open-junius changed the title [WIP] get stake interface in solidity get stake interface in solidity Nov 13, 2024
@open-junius open-junius self-assigned this Nov 13, 2024
@open-junius open-junius requested review from sam0x17, gztensor and a team November 13, 2024 10:27
Copy link
Contributor

@orriin orriin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we get a test?

@open-junius
Copy link
Contributor Author

open-junius commented Nov 13, 2024

Looks good, can we get a test?
Verified the interface via js code, let me push it into main branch of subtensor-js-tests.

https://github.com/opentensor/subtensor-js-tests/blob/main/src/evm/eth.staking.precompile.test.js#L192

@gztensor gztensor mentioned this pull request Dec 5, 2024
2 tasks
@gztensor gztensor linked an issue Dec 5, 2024 that may be closed by this pull request
2 tasks
@gztensor gztensor removed a link to an issue Dec 5, 2024
2 tasks
@gztensor gztensor linked an issue Dec 5, 2024 that may be closed by this pull request
5 tasks
@gztensor
Copy link
Contributor

gztensor commented Dec 6, 2024

Please implement the e2e test for this as a separate test and let it fail. When we merge to devnet-ready, the tests will be passing.

@open-junius
Copy link
Contributor Author

@kyriediculous
Copy link

It would be great to have this merged ! Thanks for this PR.

@sam0x17 sam0x17 requested a review from a team December 18, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view method to staking precompile to access stake map
5 participants