Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layout Matching #55

Draft
wants to merge 5 commits into
base: features/penalty_rewards
Choose a base branch
from

Conversation

bkb2135
Copy link
Contributor

@bkb2135 bkb2135 commented Oct 31, 2023

Adds layout matching task and criteria to answer step in validation.

@bkb2135 bkb2135 changed the base branch from features/penalty_rewards to staging October 31, 2023 18:49
@p-ferreira p-ferreira changed the base branch from staging to features/penalty_rewards October 31, 2023 19:23
Copy link
Contributor

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be great to have some unit tests.

@bkb2135
Copy link
Contributor Author

bkb2135 commented Nov 1, 2023

Be great to have some unit tests.

Yeah I wrote some up, how should I get these to you?

prompting/validators/criteria.py Outdated Show resolved Hide resolved

criteria = [match_words_criteria, match_length_criteria]
criteria = [match_words_criteria, match_length_criteria, match_layout_criteria]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steffencruz what's your thoughts on including the layout criteria in the 2.1.0 release? At first glance I would think that this could be challenging both to the miners and the current reward stack evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants