[rest] add query parsing #1940
Open
[rest] add query parsing #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are formatting error with your PR: https://github.com/openthread/ot-br-posix/actions/runs/5553833818/jobs/10171787035?pr=1940 Please run command |
wgtdkp
reviewed
Jul 16, 2023
src/rest/request.cpp
Outdated
Comment on lines
94
to
96
| auto it = mHeaders.find(aQueryName); | ||
|
|
||
| return (it == mHeaders.end()) ? "" : it->second; |
There was a problem hiding this comment.
Shouldn't we use mQueryParameters here?
There was a problem hiding this comment.
Yes we definitely should.
I've tested the parsing code but not the api. Looking at the automated tests its gonna be hard to test without having a endpoint that actually uses the query parameters. We have code under works that uses them but only for timeouts so that would not be testable either.
Co-authored-by: Kangping <[email protected]>
wgtdkp
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the capability to parse url query strings to the rest api.
It also contains a small refactoring of the parser and request class which moved state that is only required for parsing out of the request class. The only exception to this is the body field which is still built up in the request class.