Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[options] add an option to control power calibration #2590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Irving-cl
Copy link
Contributor

This PR adds an option to enable/disable the power calibration functionality in otbr.

The recently introduced ThreadHost API SetChannelMaxPowers depends on the radio platform API otPlatRadioSetChannelTargetPower which may not be enabled on some platforms/products. In those cases, we will have undefined symbols error. This PR adds a build option to disable the power calibration function in otbr. On those platforms/products who don't enable otPlatRadioSetChannelTargetPower, they should turn off this option as well.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.94%. Comparing base (2b41187) to head (dae21c3).
Report is 862 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/ncp_host.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   55.77%   45.94%   -9.84%     
==========================================
  Files          87      105      +18     
  Lines        6890    12577    +5687     
  Branches        0      912     +912     
==========================================
+ Hits         3843     5778    +1935     
- Misses       3047     6484    +3437     
- Partials        0      315     +315     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant