[web] refactor OTBR-WEB #537

tttttangTH · 2020-08-12T18:13:05Z

This PR refactors OTBR web with the new REST APIs:

Remove standalone otbr-web binary.
Add REST APIs that are required by the OTBR web page.
Host the OTBR web page with Nginx.
Remove unused third-party libraries.

For the new implementation, HTTP requests for static files are served by Nginx directly while requests for dynamic resources are served by OTBR agent REST APIs (requests are forwarded to OTBR agent by Nginx).

Update forks

Update fork.

Update fork

[third_party] update OpenThread (openthread#533)

lgtm-com · 2020-08-12T18:25:05Z

This pull request introduces 4 alerts and fixes 2 when merging 460107c into ecc2570 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-13T02:27:06Z

This pull request introduces 4 alerts and fixes 2 when merging b8c94db into ecc2570 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class

fixed alerts:

2 for Useless assignment to local variable

codecov · 2020-08-13T03:47:32Z

Codecov Report

Merging #537 (cc2ef9e) into master (ea8fe65) will increase coverage by 4.95%.
The diff coverage is 81.55%.

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
+ Coverage   76.67%   81.63%   +4.95%     
==========================================
  Files          76       71       -5     
  Lines        5004     4955      -49     
==========================================
+ Hits         3837     4045     +208     
+ Misses       1167      910     -257

Impacted Files	Coverage Δ
src/agent/main.cpp	`93.13% <ø> (ø)`
src/rest/connection.hpp	`100.00% <ø> (ø)`
src/rest/parser.cpp	`100.00% <ø> (+13.15%)`	⬆️
src/rest/request.cpp	`86.66% <ø> (+13.33%)`	⬆️
src/rest/request.hpp	`100.00% <ø> (ø)`
src/rest/response.hpp	`100.00% <ø> (ø)`
src/rest/rest_web_server.cpp	`88.04% <ø> (-5.44%)`	⬇️
src/rest/connection.cpp	`74.80% <16.66%> (+0.92%)`	⬆️
src/rest/resource.cpp	`85.89% <80.52%> (-4.87%)`	⬇️
src/rest/json.cpp	`82.39% <86.45%> (+4.62%)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8fe65...cc2ef9e. Read the comment docs.

lgtm-com · 2020-08-13T09:18:23Z

This pull request introduces 19 alerts and fixes 2 when merging 66e867a into ecc2570 - view on LGTM.com

new alerts:

12 for Unused variable, import, function or class
7 for Missing variable declaration

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-19T17:11:03Z

This pull request introduces 3 alerts and fixes 2 when merging 40adcb6 into e3cbbf7 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Expression has no effect

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-19T17:26:42Z

This pull request introduces 3 alerts and fixes 2 when merging ff5686d into e3cbbf7 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Expression has no effect

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-19T17:38:18Z

This pull request introduces 3 alerts and fixes 2 when merging d364350 into e3cbbf7 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Expression has no effect

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-19T18:03:22Z

This pull request fixes 2 alerts when merging 8cc43f3 into e3cbbf7 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

[cmake] add option for enabling legacy in cmake (openthread#544)

lgtm-com · 2020-08-21T00:23:13Z

This pull request fixes 2 alerts when merging ccb2e69 into e3cbbf7 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-21T00:45:56Z

This pull request fixes 2 alerts when merging 46a1fe8 into e3cbbf7 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-21T01:53:00Z

This pull request fixes 2 alerts when merging 6f8a8fe into e3cbbf7 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-21T03:19:51Z

This pull request fixes 2 alerts when merging 44142f7 into e3cbbf7 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-26T15:30:31Z

This pull request fixes 2 alerts when merging d83733c into bc8825d - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

lgtm-com · 2020-08-26T15:56:02Z

This pull request fixes 2 alerts when merging 5694906 into bc8825d - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable

tttttangTH · 2020-09-02T18:14:21Z

Have rebased it with newly merged #519, I will also have a self review these two days. @wgtdkp

script/bootstrap

script/setup

src/CMakeLists.txt

src/rest/connection.cpp

src/rest/frontend/index.html

src/rest/frontend/res/js/app.js

src/rest/json.hpp

src/rest/request.hpp

wgtdkp

I also made some changes (mainly about Nginx & CMake scripts) to make it works for me and this PR LGTM now. Thanks to @tttttangTH, we are seeing a significant coverage increase of more that 5%!

@bukepo @jwhui Any comments?

bukepo · 2021-05-02T07:02:16Z

etc/rest/otbr-nginx.conf

+                index  index.html;
+        }
+        location /v1/ {
+                proxy_pass  http://0.0.0.0:8081;


allows customize port number?

bukepo · 2021-05-02T07:04:18Z

src/rest/resource.hpp


 private:
    typedef void (Resource::*ResourceHandler)(const Request &aRequest, Response &aResponse) const;
    typedef void (Resource::*ResourceCallbackHandler)(const Request &aRequest, Response &aResponse);
+
+    // RESTful API entry


Can we add a document describing the REST APIs?

Tonghui Tang added 4 commits July 10, 2020 12:06

Merge pull request #1 from openthread/master

35a099f

Update forks

Merge pull request #3 from openthread/master

79c820f

Update fork.

Merge pull request #4 from openthread/master

78abefe

Update fork

Merge pull request #5 from openthread/master

1b4fc20

[third_party] update OpenThread (openthread#533)

tttttangTH requested review from bukepo, jwhui, simonlingoogle and wgtdkp August 12, 2020 18:13

googlebot added the cla: yes label Aug 12, 2020

tttttangTH mentioned this pull request Aug 14, 2020

[web] topology visualization #519

Merged

tttttangTH changed the title ~~[web] Refactor OTBR-WEB~~ [web] refactor OTBR-WEB Aug 14, 2020

tttttangTH marked this pull request as ready for review August 19, 2020 17:58

Merge pull request #8 from openthread/master

78dcfcb

[cmake] add option for enabling legacy in cmake (openthread#544)

tttttangTH commented Sep 6, 2020

View reviewed changes

script/bootstrap Outdated Show resolved Hide resolved

script/setup Outdated Show resolved Hide resolved

src/CMakeLists.txt Show resolved Hide resolved

src/rest/connection.cpp Show resolved Hide resolved

tttttangTH commented Sep 7, 2020

View reviewed changes

tttttangTH force-pushed the manager-web branch 2 times, most recently from 8fd94c4 to 3178101 Compare October 3, 2020 16:54

tttttangTH force-pushed the manager-web branch from 3178101 to 60a7974 Compare October 13, 2020 13:16

replace otbr-web

518ca34

tttttangTH force-pushed the manager-web branch from 35094e4 to 518ca34 Compare October 14, 2020 02:10

wgtdkp added 5 commits October 14, 2020 11:00

[3rd-party] remove simple web server

ec59312

[cmake] fix cmake installing frontend scripts

5ceacdc

[scripts] refine scripts setting up OTBR web with Nginx

a8ccdf6

[rest] refine code style

132e678

[rest] remove unused nginx config file

c0d74ae

wgtdkp approved these changes Oct 14, 2020

View reviewed changes

tttttangTH mentioned this pull request Oct 14, 2020

OTBR_REST=ON: compile error in hash table of status codes #587

Closed

tttttangTH added 2 commits October 14, 2020 12:28

Merge branch 'master' of github.com:openthread/ot-br-posix

cfdf654

Merge branch 'master' of github.com:openthread/ot-br-posix

9fca097

tttttangTH mentioned this pull request Oct 21, 2020

[web] fix rest-test issues #593

Open

wgtdkp force-pushed the manager-web branch from c4951d1 to 79443b0 Compare October 22, 2020 05:51

wgtdkp added 2 commits October 22, 2020 13:59

resolve conflicts with the master branch

81bb2d0

merge master branch

ea3e175

wgtdkp force-pushed the manager-web branch from 79443b0 to ea3e175 Compare October 22, 2020 06:04

wgtdkp requested review from simonlingoogle and removed request for simonlingoogle October 27, 2020 06:10

tttttangTH added 3 commits November 8, 2020 20:30

Merge branch 'master' of github.com:openthread/ot-br-posix

f4b8547

reslove conflicts

d64e793

change function name 'SetCallback' as 'SetHasCallback'

cc2ef9e

Base automatically changed from master to main March 8, 2021 21:50

bukepo assigned wgtdkp May 2, 2021

bukepo reviewed May 2, 2021

View reviewed changes

wgtdkp mentioned this pull request Dec 20, 2022

[web] bump to latest Simple-Web-Server version #1667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] refactor OTBR-WEB #537

[web] refactor OTBR-WEB #537

tttttangTH commented Aug 12, 2020 •

edited by wgtdkp

Loading

lgtm-com bot commented Aug 12, 2020

lgtm-com bot commented Aug 13, 2020

codecov bot commented Aug 13, 2020 •

edited

Loading

lgtm-com bot commented Aug 13, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 26, 2020

tttttangTH commented Sep 2, 2020

wgtdkp left a comment •

edited

Loading

bukepo May 2, 2021

bukepo May 2, 2021

[web] refactor OTBR-WEB #537

Are you sure you want to change the base?

[web] refactor OTBR-WEB #537

Conversation

tttttangTH commented Aug 12, 2020 • edited by wgtdkp Loading

lgtm-com bot commented Aug 12, 2020

lgtm-com bot commented Aug 13, 2020

codecov bot commented Aug 13, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Aug 13, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 19, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 21, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 26, 2020

tttttangTH commented Sep 2, 2020

wgtdkp left a comment • edited Loading

Choose a reason for hiding this comment

bukepo May 2, 2021

Choose a reason for hiding this comment

bukepo May 2, 2021

Choose a reason for hiding this comment

tttttangTH commented Aug 12, 2020 •

edited by wgtdkp

Loading

codecov bot commented Aug 13, 2020 •

edited

Loading

wgtdkp left a comment •

edited

Loading