-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker build instructions #252
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seems that this could be useful for users.
Could you please add a link to the DevZone guide? https://devzone.nordicsemi.com/guides/nrf-connect-sdk-guides/b/getting-started/posts/build-ncs-application-firmware-images-using-docker
And replicate the information to the other SoCs READMEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing at @edmont 's request.
|
||
Alternatively, it's possible to build using a Docker image. | ||
|
||
This can be useful in case of CI/CD builds or to build locally without installing the dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is CI/CD in this case? Do the abbreviations need to be opened?
Are there downsides? For example, is the user foregoing all the support options (USB CDC ACM support, Bootloader support, and so on)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to say when building in a pipeline in the cloud, most of the time the build agent will run some generic OS and the build agent can be instructed to run our pipeline script in a specific container image.
In this case, building through the docker image can help better control the build environment over time and give better odds of a build not failing if the cloud provider updates the VM environment.
I don't know of any downsides but my tests were limited to the sample build I provided as an example in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, that sounds good and doesn't necessitate any more clarification, I think.
Co-authored-by: Wille Backman <[email protected]>
Co-authored-by: Wille Backman <[email protected]>
Co-authored-by: Wille Backman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the writing front.
Co-authored-by: Wille Backman <[email protected]>
@fgervais do you mind updating |
Co-authored-by: Wille Backman <[email protected]>
Many thanks @wiba-nordic for the rewording and both of you for the live review :). @edmont sure, I will remove the |
No problem. Thanks for being quick to respond to the change requests. :) |
Yes please. |
Co-authored-by: Eduardo Montoya <[email protected]>
There is still a little mistake I just figured, give me a minute. |
Since last commit, everything is ready on my side. |
|
||
```bash | ||
cd <path-to-ot-nrf528xx> | ||
docker run --rm -u $(id -u):$(id -g) -v $(pwd):/workdir/project coderbyheart/fw-nrfconnect-nrf-docker:v1.8-branch ./script/build nrf52811 UART_trans -DOT_THREAD_VERSION=1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuDuda @MarekPorwisz , are you OK with recommending use of this Docker image?
Show how openthread can also be built through docker.
This is using the image from coderbyheart which I think is as official as we can get right now for an nRF Connect SDK docker image.
Following is the build output of current latest
8c6658f6263a8ec1e8135534133a96770b9bb065
using imagesha256:2af43c0b698b5bae084eea409a46ac63006485dde46e34cd7cc25e8b29fca082
: