Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop time fetching in added or replacement trips #6245

Open
wants to merge 4 commits into
base: dev-2.x
Choose a base branch
from

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Nov 8, 2024

Summary

This fixes problems when reading stop times for added or replacement trips.

Issue

Fixes #6088
Fixes #6242

Unit tests

GraphQL Integration tests are added for one added trip and one replacement trip. This is the first time real-time updates can be integration tested.

Documentation

None needed

@miklcct miklcct requested a review from a team as a code owner November 8, 2024 15:52
@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch from 36ef65d to ed3bb9b Compare November 8, 2024 15:53
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (ee53e50) to head (38c3a5a).
Report is 124 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...entripplanner/apis/gtfs/datafetchers/TripImpl.java 76.47% 5 Missing and 3 partials ⚠️
...java/org/opentripplanner/model/TripTimeOnDate.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6245      +/-   ##
=============================================
- Coverage      69.91%   69.84%   -0.08%     
+ Complexity     17736    17698      -38     
=============================================
  Files           2006     2007       +1     
  Lines          75526    75655     +129     
  Branches        7730     7747      +17     
=============================================
+ Hits           52804    52839      +35     
- Misses         20036    20100      +64     
- Partials        2686     2716      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch 3 times, most recently from 428a549 to df345c2 Compare November 8, 2024 16:08
@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch from df345c2 to 38c3a5a Compare November 8, 2024 16:12
@t2gran t2gran added this to the 2.7 (next release) milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants