-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: Location field dropdown ID #615
a11y: Location field dropdown ID #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small UI issue but overall this looks really good!
so that assistive technology can associate the list with the button and input controls. */} | ||
<ItemList | ||
// Hide the list from screen readers if no enabled options are shown. | ||
aria-hidden={hasNoEnabledOptions} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I thought I covered that during initial dev, but it didn't work after a fresh compile. Fixed in 0657fd8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes thanks!
This PR makes the dropdown and its ID continuously visible in the DOM and from the DOM elements that control the dropdown.