Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST/APPS: Fixed building rpm. #10358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TEST/APPS: Fixed building rpm. #10358

wants to merge 1 commit into from

Conversation

rakhmets
Copy link
Collaborator

@rakhmets rakhmets commented Dec 5, 2024

What?

Fixed the following scenario:

$ ./autogen.sh
$ ./contrib/configure-release --with-java=no
$ ./contrib/buildrpm.sh -s -t -b
...
nvcc fatal   : Could not open output file .deps/test_cuda_get_symbol_address.Tpo

@Alexey-Rivkin
Copy link
Collaborator

/azp run UCX release

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakhmets rakhmets force-pushed the topic/fix-buildrpm-w-cuda branch from 50ce59c to cb3e27c Compare December 5, 2024 18:57
yosefe
yosefe reviewed Dec 5, 2024
View reviewed changes
test/apps/Makefile.am Outdated
`test -f '$<' || echo '$(srcdir)/'`$<
$(AM_V_at)$(am__mv) $(DEPDIR)/test_cuda_get_symbol_address.Tpo \
$(DEPDIR)/test_cuda_get_symbol_address.Po
@am__fastdepCC_TRUE@ $(AM_V_CC)$(NVCC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(test_cuda_get_symbol_address_CPPFLAGS) -Xcompiler "$(CPPFLAGS) $(CFLAGS)" -MT $@ -MD -MF $(DEPDIR)/test_cuda_get_symbol_address.Tpo -c -o $@ `test -f 'test_cuda_get_symbol_address.cu' || echo '$(srcdir)/'`test_cuda_get_symbol_address.cu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to make this simpler? maybe some kind of intermediate/explicit dependency?
what is the issue being solved here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same command line that is autogenerated and used to build objects from .c files. The only difference are: $(NVCC) instead of $(CC), -Xcompiler to pass options not supported by nvcc, and the absence of -MP option.

@am__fastdepCC_TRUE@, @AMDEP_TRUE@@am__fastdepCC_FALSE@, @am__fastdepCC_FALSE@ are used to comment out the unused lines depending on the build type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way to avoid taking the autogenerated command and instead just tweak some automake vars?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least remove some parts of the command which are not essential?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find an easier way to use two different command line for different compilers. I can try to simplify the command line a little. However, I do not know any other ways to support different command lines for make/make dist/etc... other than using the same variables to comment out the lines.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so let's try to simplify it

@Alexey-Rivkin Alexey-Rivkin mentioned this pull request Dec 16, 2024
Open
@rakhmets rakhmets requested a review from yosefe December 19, 2024 17:54
@rakhmets rakhmets mentioned this pull request Jan 7, 2025
Open
@rakhmets rakhmets force-pushed the topic/fix-buildrpm-w-cuda branch from 2b321ef to c7e1c6a Compare January 13, 2025 08:27
@yosefe yosefe enabled auto-merge January 13, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakhmets @Alexey-Rivkin @yosefe