CONFIG: Add external flags to configure output #10378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Dec 17, 2024
configure.ac
Outdated
| @@ -409,6 +409,9 @@ AC_MSG_NOTICE([ Configuration dir: ${ucx_config_dir}]) | |||
| AC_MSG_NOTICE([ Preprocessor flags: ${BASE_CPPFLAGS}]) | |||
| AC_MSG_NOTICE([ C compiler: ${CC} ${BASE_CFLAGS}]) | |||
| AC_MSG_NOTICE([ C++ compiler: ${CXX} ${BASE_CXXFLAGS}]) | |||
| AC_MSG_NOTICE([ CFLAGS: ${CFLAGS}]) | |||
| AC_MSG_NOTICE([ CPPFLAGS: ${CPPFLAGS}]) | |||
| AC_MSG_NOTICE([ CXXFLAGS: ${CXXFLAGS}]) | |||
There was a problem hiding this comment.
WDYT to unite the printing of BASE_CFLAGS and BASE_CXXFLAGS with the new output of CFLAGS/CPP/CXXFLAGS? to separate the print of compiler executable and the compilation flags
There was a problem hiding this comment.
pushed below:
configure: =========================================================
configure: UCX build configuration:
configure: Build prefix: /usr
configure: Configuration dir: /etc/ucx
configure: CC: gcc
configure: CXX: g++
configure: BASE_CPPFLAGS: -DCPU_FLAGS="" -I${abs_top_srcdir}/src -I${abs_top_builddir} -I${abs_top_builddir}/src
configure: BASE_CFLAGS: -O3 -g -Wall -Werror -fno-omit-frame-pointer -funwind-tables -Wframe-larger-than=8192 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement
configure: BASE_CXXFLAGS: -O3 -g -Wall -Werror -fno-omit-frame-pointer -funwind-tables -Wframe-larger-than=8192 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch
configure: CPPFLAGS: -I/usr/include
configure: CFLAGS:
configure: CXXFLAGS: -Wall
configure: ASAN check: no
configure: Multi-thread: enabled
There was a problem hiding this comment.
IMO unite
CPPFLAGS + BASE_CPPFLAGS
CFLAGS + BASE_CFLAGS
CXXFLAGS + BASE_CXXFLAGS
There was a problem hiding this comment.
pushed, I ordered base_cflags before cflags as they are more likely to be used in this order. tbh I prefer the previous version, in case other flags would be inserted between base_cflags and cflags this does not create false promise.
configure: CC: gcc
configure: CXX: g++
configure: CPPFLAGS: -DCPU_FLAGS="" -I${abs_top_srcdir}/src -I${abs_top_builddir} -I${abs_top_builddir}/src -Wall -I/usr/include
configure: CFLAGS: -O3 -g -Wall -Werror -fno-omit-frame-pointer -funwind-tables -Wframe-larger-than=8192 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wno-pointer-sign -Werror-implicit-function-declaration -Wno-format-zero-length -Wnested-externs -Wshadow -Werror=declaration-after-statement -Wall
configure: CXXFLAGS: -O3 -g -Wall -Werror -fno-omit-frame-pointer -funwind-tables -Wframe-larger-than=8192 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-label -Wno-long-long -Wno-endif-labels -Wno-sign-compare -Wno-multichar -Wno-deprecated-declarations -Winvalid-pch -Wall
configure: ASAN check: no
tvegas1
force-pushed
the
configure_flags
branch
from
4987e09 to
9baa36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add external flags to configure output, others are already output as part of compiler command line.