replace some constants with their more adapted counterpart #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wifi_interface_t` is more or less equivalent to `esp_interface_t` and the values are the same, however in terms of argument type it's more consistent to use `wifi_interface_t` for `esp_wifi_set_bandwidth()` and `esp_wifi_get_mac()` Signed-off-by: Ludovic LANGE <[email protected]>
llange
force-pushed
the
replace-wifi-deprecated-constants
branch
from
3f6d82c
to
13d17fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wifi_interface_tis more or less equivalent toesp_interface_tand the values are the same, however in terms of argument type it's more consistent to usewifi_interface_tforesp_wifi_set_bandwidth()andesp_wifi_get_mac().Cf:
Cf #806 / #810
Signed-off-by: Ludovic LANGE [email protected]