Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use SSE flags on arm64 platform #679

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Do not use SSE flags on arm64 platform #679

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e36f859
Do not use SSE flags on arm64 platform
SiarheiFedartsou Dec 3, 2024
ff623ae
Do not use SSE flags on arm64 platform
SiarheiFedartsou Dec 3, 2024
4f51945
[github] no need to use macos-15-latest which requires upgrading, jus…
albarrentine Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ jobs:
build_and_test:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
os:
- ubuntu-latest
- macos-15-large # x86_64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a bit confusing, but it is indeed how GH Actions define arm64 and x86_64 images :)

- macos-15 # arm64
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ AC_ARG_ENABLE([sse2],
)
)

AS_IF([test "x$enable_sse2" != "xno"], [
AS_IF([test "x$enable_sse2" != "xno" && test "x$(uname -m)" != "xarm64"], [
CFLAGS="-mfpmath=sse -msse2 -DUSE_SSE ${CFLAGS}"
])

Expand Down
Loading