Skip to content

Commit

Permalink
Do not install editable NNCF in workflows (#2054)
Browse files Browse the repository at this point in the history
### Changes
Now doing `pip install .` instead of `pip install -e .` in GH Actions
workflow files.

### Reason for changes
Ubuntu 22 and pip/setuptools have a lot of bugs when installing editable
packages with the new build isolation flow (e.g. when the pyproject.toml
is present). We don't have pyproject.toml yet, but should we need to
switch, better to have less failures in the unrelated tests and
workflows - we don't really need editability in GH actions we have now.

### Related tickets

N/A

### Tests
Can only test changes in these workflows post-factum.
  • Loading branch information
vshampor authored Aug 17, 2023
1 parent 27ec0ad commit de10012
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_html_doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
ref: ${{ inputs.ref }}
- name: Install NNCF and doc requirements
run: |
pip install -e .
pip install .
pip install -r docs/api/requirements.txt
- name: Build API docs
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_schema_page.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Install and Build
run: |
pip install json-schema-for-humans
pip install -e .
pip install .
python -c 'import jstyleson; from nncf.config import NNCFConfig; jstyleson.dump(NNCFConfig.schema(), open("./schema.json", "w"), indent=2)'
mkdir schema
generate-schema-doc --deprecated-from-description schema.json schema/index.html
Expand Down

0 comments on commit de10012

Please sign in to comment.