Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ][Micro refactoring] Refactor insert null bias to insert bias with value #2056

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Aug 17, 2023

Changes

Refactor insert null bias to insert bias with value

Reason for changes

To make it possible to insert bias with a value. This is needed for the ChannelAlignment algorithm

Related tickets

114583

Tests

  • tests/openvino/native/test_model_transformer.py updated
  • tests/openvino/native/test_model_utils.py presented

@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner August 17, 2023 16:57
@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Aug 17, 2023
@daniil-lyakhov daniil-lyakhov changed the title [PTQ] Refactor insert null bias to insert bias with value [PTQ][Micro refactoring] Refactor insert null bias to insert bias with value Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2056 (d5d5423) into develop (a1074e7) will increase coverage by 3.15%.
Report is 11 commits behind head on develop.
The diff coverage is 15.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2056      +/-   ##
===========================================
+ Coverage    32.93%   36.08%   +3.15%     
===========================================
  Files          476      476              
  Lines        42391    42417      +26     
===========================================
+ Hits         13961    15306    +1345     
+ Misses       28430    27111    -1319     
Files Changed Coverage Δ
nncf/openvino/graph/model_transformer.py 0.00% <0.00%> (ø)
nncf/openvino/graph/model_utils.py 0.00% <0.00%> (ø)
nncf/openvino/graph/node_utils.py 0.00% <0.00%> (ø)
...openvino/graph/transformations/command_creation.py 0.00% <0.00%> (ø)
nncf/openvino/graph/transformations/commands.py 0.00% <0.00%> (ø)
nncf/quantization/algorithms/algorithm.py 100.00% <ø> (ø)
nncf/torch/model_transformer.py 35.44% <0.00%> (ø)
nncf/torch/model_creation.py 36.26% <33.33%> (-0.10%) ⬇️
...quantization/algorithms/post_training/algorithm.py 76.85% <100.00%> (+0.66%) ⬆️

... and 43 files with indirect coverage changes

@daniil-lyakhov
Copy link
Collaborator Author

@KodiaqQ, @andrey-churkin please ignore codecov report as it is working in a wrong way

nncf/openvino/graph/model_utils.py Outdated Show resolved Hide resolved
nncf/openvino/graph/model_utils.py Outdated Show resolved Hide resolved
@daniil-lyakhov
Copy link
Collaborator Author

run pytorch pre-commit tests

nncf/openvino/graph/model_transformer.py Show resolved Hide resolved
nncf/openvino/graph/node_utils.py Outdated Show resolved Hide resolved
@KodiaqQ KodiaqQ merged commit 61538a2 into openvinotoolkit:develop Aug 25, 2023
6 checks passed
andreyanufr pushed a commit to andreyanufr/nncf that referenced this pull request Sep 12, 2023
…h value (openvinotoolkit#2056)

### Changes

Refactor insert null bias to insert bias with value
### Reason for changes

To make it possible to insert bias with a value. This is needed for the
ChannelAlignment algorithm

### Related tickets

114583

### Tests
* tests/openvino/native/test_model_transformer.py updated
* tests/openvino/native/test_model_utils.py presented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants