Only launch pytest with coverage in Makefile if env var is set #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2072 +/- ##
===========================================
+ Coverage 32.93% 36.08% +3.14%
===========================================
Files 476 476
Lines 42391 42408 +17
===========================================
+ Hits 13961 15302 +1341
+ Misses 28430 27106 -1324
|
KodiaqQ
approved these changes
Aug 22, 2023
daniil-lyakhov
pushed a commit
to daniil-lyakhov/nncf
that referenced
this pull request
Aug 25, 2023
…inotoolkit#2072) ### Changes Setting `NNCF_COVERAGE` env var will make commands such as `make test-torch` run pytest with `coverage` reports generated, otherwise the pytest runs without `coverage. ### Reason for changes Devs can now launch Makefile commands without running coverage by default, and if they really need to, they can prefix the make command: `NNCF_COVERAGE=1 make test-torch`. ### Related tickets N/A ### Tests precommit
andreyanufr
pushed a commit
to andreyanufr/nncf
that referenced
this pull request
Sep 12, 2023
…inotoolkit#2072) ### Changes Setting `NNCF_COVERAGE` env var will make commands such as `make test-torch` run pytest with `coverage` reports generated, otherwise the pytest runs without `coverage. ### Reason for changes Devs can now launch Makefile commands without running coverage by default, and if they really need to, they can prefix the make command: `NNCF_COVERAGE=1 make test-torch`. ### Related tickets N/A ### Tests precommit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Setting
NNCF_COVERAGEenv var will make commands such asmake test-torchrun pytest withcoveragereports generated, otherwise the pytest runs without `coverage.Reason for changes
Devs can now launch Makefile commands without running coverage by default, and if they really need to, they can prefix the make command:
NNCF_COVERAGE=1 make test-torch.Related tickets
N/A
Tests
precommit