Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ][OV] Support GroupConvolution with ShapeOf case #2076

Closed

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Aug 22, 2023

Changes

  • Added support for weights quantization of GroupConvolution with ShapeOf

Reason for changes

  • Proper quantization scheme. Currently, weights for this case not quantizable.

Related tickets

  • 113647

Tests

  • Added test case

Currently, it's possible that model from the TF framework can contain a ShapeOf subgraph for weights of GroupConvolution:
image

Updated quantization scheme. Weights quantized (not decomposed):
image

@KodiaqQ KodiaqQ added the NNCF PTQ Pull requests that updates NNCF PTQ label Aug 22, 2023
@KodiaqQ KodiaqQ requested a review from l-bat August 22, 2023 13:59
@KodiaqQ KodiaqQ requested a review from a team as a code owner August 22, 2023 13:59
@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO and removed NNCF PTQ Pull requests that updates NNCF PTQ labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2076 (f4f2f9c) into develop (8bf5a12) will increase coverage by 20.77%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2076       +/-   ##
============================================
+ Coverage    15.31%   36.08%   +20.77%     
============================================
  Files          476      476               
  Lines        42408    42405        -3     
============================================
+ Hits          6494    15302     +8808     
+ Misses       35914    27103     -8811     
Files Changed Coverage Δ
nncf/openvino/graph/nncf_graph_builder.py 0.00% <ø> (ø)

... and 209 files with indirect coverage changes

@KodiaqQ
Copy link
Collaborator Author

KodiaqQ commented Aug 22, 2023

Still validating locally. Found an issue with the FQ constants shape.

@KodiaqQ KodiaqQ marked this pull request as draft August 24, 2023 11:52
@KodiaqQ KodiaqQ closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants