Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some methods for NNCF 2.6 release #2083

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Deprecate some methods for NNCF 2.6 release #2083

merged 5 commits into from
Aug 29, 2023

Conversation

nikita-savelyevv
Copy link
Collaborator

Changes

Some methods were left for backward compatibility after #1584 and are due for deletion before NNCF 2.6 release.

@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner August 24, 2023 13:32
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #2083 (f4e2fc3) into develop (c027c8b) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2083   +/-   ##
========================================
  Coverage    36.08%   36.09%           
========================================
  Files          476      476           
  Lines        42412    42408    -4     
========================================
+ Hits         15306    15307    +1     
+ Misses       27106    27101    -5
Files Changed Coverage Δ
...torch/sparsity/movement/structured_mask_handler.py 24.55% <0.00%> (ø)
nncf/torch/nncf_network.py 28.95% <ø> (+0.08%) ⬆️

... and 6 files with indirect coverage changes

@nikita-savelyevv
Copy link
Collaborator Author

run pytorch pre-commit tests

@nikita-savelyevv
Copy link
Collaborator Author

run pytorch pre-commit tests

@vshampor vshampor merged commit beff3a4 into openvinotoolkit:develop Aug 29, 2023
6 checks passed
nikita-savelyevv added a commit to nikita-savelyevv/nncf that referenced this pull request Aug 29, 2023
@nikita-savelyevv
Deprecate some methods for NNCF 2.6 release (openvinotoolkit#2083)
925c1e6 
### Changes

Some methods were left for backward compatibility after openvinotoolkit#1584 and are
due for deletion before NNCF 2.6 release.
@nikita-savelyevv nikita-savelyevv mentioned this pull request Aug 29, 2023
Merged
vshampor pushed a commit that referenced this pull request Aug 29, 2023
@nikita-savelyevv
[Release] Deprecate some methods for NNCF 2.6 release (#2088)
b4d72b4 
### Changes

Copy of #2083 to release branch.
@nikita-savelyevv nikita-savelyevv deleted the deprecate-some-nncf-network-methods branch September 25, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshampor vshampor vshampor approved these changes

Assignees
No one assigned
Labels
experimental NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-savelyevv @vshampor