Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ultralytics to 8.0.170 #2133

Merged

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Sep 12, 2023

Changes

Upgrade ultralytics to 8.0.170

Reason for changes

For some reason yolo samples started to fail. Upgrading ultralytics solves this issue because the later version contains these changes: ultralytics/ultralytics@a741961

Related tickets

120311

Tests

Build 82 passed

@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Sep 12, 2023
@nikita-savelyevv nikita-savelyevv marked this pull request as ready for review September 12, 2023 17:20
@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner September 12, 2023 17:20
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2133 (0ddd261) into develop (0a08966) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2133      +/-   ##
===========================================
- Coverage    35.92%   35.92%   -0.01%     
===========================================
  Files          476      476              
  Lines        42483    42494      +11     
===========================================
+ Hits         15264    15265       +1     
- Misses       27219    27229      +10     

see 3 files with indirect coverage changes

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you upgrade ultralytics to 8.0.170 instead off the latest version?

@nikita-savelyevv
Copy link
Collaborator Author

run pylint pre-commit tests
run pytorch pre-commit tests
run tensorflow pre-commit tests
run openvino pre-commit tests
run onnx pre-commit tests

@nikita-savelyevv
Copy link
Collaborator Author

nikita-savelyevv commented Sep 13, 2023

Why did you upgrade ultralytics to 8.0.170 instead off the latest version?

There is no particular reason, other than slightly lower risks of bugs since ultralytics is released almost every day. For example, 8.0.174 has been marked as YANKED.

@alexsu52 alexsu52 merged commit 8cdba7f into openvinotoolkit:develop Sep 13, 2023
6 checks passed
nikita-savelyevv added a commit to nikita-savelyevv/nncf that referenced this pull request Sep 13, 2023
### Changes

Upgrade ultralytics to 8.0.170

### Reason for changes

For some reason yolo samples started to fail. Upgrading ultralytics
solves this issue because the later version contains these changes:
ultralytics/ultralytics@a741961

### Related tickets

120311

### Tests

Build 82 passed
KodiaqQ pushed a commit that referenced this pull request Sep 13, 2023
### Changes

Copy of #2133 to release branch.
@nikita-savelyevv nikita-savelyevv deleted the upgrade-ultralytics branch September 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants