Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torch for CUDA 11.8 in tests #2149

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

vshampor
Copy link
Contributor

No description provided.

@vshampor vshampor requested a review from a team as a code owner September 20, 2023 10:30
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2149 (e8a9003) into develop (50feea4) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2149      +/-   ##
===========================================
+ Coverage    36.23%   36.24%   +0.01%     
===========================================
  Files          477      477              
  Lines        42544    42570      +26     
===========================================
+ Hits         15414    15428      +14     
- Misses       27130    27142      +12     

see 6 files with indirect coverage changes

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -117,11 +117,11 @@ test-examples-tensorflow:
# PyTorch backend
install-torch-test:
pip install -U pip
pip install -e .[torch]
pip install -r tests/torch/requirements.txt
pip install -e .[torch] --index-url https://download.pytorch.org/whl/cu118 --extra-index-url=https://pypi.org/simple # ticket 119128
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to pip install -e .[torch] --extra-index-url=https://download.pytorch.org/whl/cu118 it's still install torch-2.0.1%2Bcu118-cp310-cp310-linux_x86_64.whl.
Looks like it can be replaced pip install -e .[torch] --extra-index-url=https://download.pytorch.org/whl/cu118

With torch==2.0.1+cu118 bug is not reproduced 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I tried too, but it didn't work in precommit. At the same time it works locally, maybe pip version is at fault. This is a temporary solution anyway until default torch starts shipping for CUDA 11.8.

@vshampor vshampor merged commit b16d4a1 into openvinotoolkit:develop Sep 27, 2023
6 checks passed
daniil-lyakhov pushed a commit to daniil-lyakhov/nncf that referenced this pull request Sep 27, 2023
@vshampor vshampor deleted the fix_segfault branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants