Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar visuals enhancement #2162

Merged

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Sep 26, 2023

Changes

  • Progress bar now extends to screen width
  • Iteration count, time spent and time remaining text components are now Intel blue (RGB [0,104,181])

How it looks in terminal (Windows Terminal):
image

How it looks in Jupyter:
image

Please see how it looked before at #2132

Note: I've tried changing color for progress percent too, but couldn't, most probably due to a bug in rich Textualize/rich#3133

Reason for changes

  • Improving user experience

Special thanks to @AlexanderDokuchaev and @kshpv for suggesting these changes.

@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner September 26, 2023 11:19
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Sep 26, 2023
@nikita-savelyevv nikita-savelyevv changed the title Progress bar visuals enhacements Progress bar visuals enhancement Sep 26, 2023
nncf/common/logging/track_progress.py Show resolved Hide resolved
nncf/common/logging/track_progress.py Outdated Show resolved Hide resolved
nncf/common/logging/track_progress.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2162 (28558ad) into develop (def8009) will increase coverage by 0.03%.
Report is 5 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2162      +/-   ##
===========================================
+ Coverage    36.09%   36.12%   +0.03%     
===========================================
  Files          478      478              
  Lines        42757    42711      -46     
===========================================
- Hits         15432    15429       -3     
+ Misses       27325    27282      -43     
Files Coverage Δ
nncf/common/logging/track_progress.py 87.93% <100.00%> (+1.65%) ⬆️

... and 6 files with indirect coverage changes

@alexsu52 alexsu52 merged commit bfefa7c into openvinotoolkit:develop Oct 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants