-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar visuals enhancement #2162
Merged
alexsu52
merged 5 commits into
openvinotoolkit:develop
from
nikita-savelyevv:progress-bar-colors
Oct 3, 2023
Merged
Progress bar visuals enhancement #2162
alexsu52
merged 5 commits into
openvinotoolkit:develop
from
nikita-savelyevv:progress-bar-colors
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-savelyevv
changed the title
Progress bar visuals enhacements
Progress bar visuals enhancement
Sep 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2162 +/- ##
===========================================
+ Coverage 36.09% 36.12% +0.03%
===========================================
Files 478 478
Lines 42757 42711 -46
===========================================
- Hits 15432 15429 -3
+ Misses 27325 27282 -43
|
AlexanderDokuchaev
approved these changes
Sep 27, 2023
MaximProshin
approved these changes
Sep 28, 2023
kshpv
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How it looks in terminal (Windows Terminal):
How it looks in Jupyter:
Please see how it looked before at #2132
Note: I've tried changing color for progress percent too, but couldn't, most probably due to a bug in rich Textualize/rich#3133
Reason for changes
Special thanks to @AlexanderDokuchaev and @kshpv for suggesting these changes.