Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor dispatcher #2660

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Apr 26, 2024

Changes

Added dispatcher for tensor to simplify register function, that base on signature of functions.
Removed _binary_op_nowarn, _binary_reverse_op_nowarn

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner April 26, 2024 19:16
@github-actions github-actions bot added documentation Improvements or additions to documentation experimental labels Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 62.72727% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 30.05%. Comparing base (bdc144b) to head (a6e07b7).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2660       +/-   ##
============================================
- Coverage    46.81%   30.05%   -16.76%     
============================================
  Files          493      493               
  Lines        45540    45488       -52     
============================================
- Hits         21318    13671     -7647     
- Misses       24222    31817     +7595     
Files Coverage Δ
nncf/experimental/tensor/functions/linalg.py 100.00% <100.00%> (ø)
nncf/experimental/tensor/functions/numeric.py 100.00% <100.00%> (+6.21%) ⬆️
nncf/experimental/tensor/functions/numpy_linalg.py 83.33% <100.00%> (-16.67%) ⬇️
...ncf/experimental/tensor/functions/numpy_numeric.py 67.71% <100.00%> (-26.41%) ⬇️
nncf/experimental/tensor/functions/torch_linalg.py 33.33% <0.00%> (-50.01%) ⬇️
nncf/experimental/tensor/tensor.py 52.83% <0.00%> (-37.83%) ⬇️
nncf/experimental/tensor/functions/dispatcher.py 63.29% <62.82%> (-31.71%) ⬇️
...ncf/experimental/tensor/functions/torch_numeric.py 0.00% <0.00%> (-56.88%) ⬇️

... and 365 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.05% <62.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 76.35% <ø> (+6.67%) ⬆️
torch 0.01% <0.00%> (-32.85%) ⬇️
tensorflow 93.74% <ø> (+93.74%) ⬆️
onnx 0.00% <ø> (-93.07%) ⬇️
openvino 0.00% <ø> (-94.19%) ⬇️
ptq 15.54% <ø> (-63.80%) ⬇️

@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as draft October 22, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants