Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Remove unreached step #2893

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

Remove "Add release label" step

Reason for changes

The condition ${{ contains(github.event.pull_request.base.ref, 'release_v') }} will never be True, because this action triggered only for a pull request to develop branch.

on:
  pull_request:
    branches:
      - develop

Label release target should be added by #2836

@AlexanderDokuchaev
Copy link
Collaborator Author

Sine #2077 , there is no any PR with target_release label https://github.com/openvinotoolkit/nncf/pulls?q=label%3A%22release_target%22+

@KodiaqQ KodiaqQ merged commit 3bda8f2 into openvinotoolkit:develop Aug 20, 2024
13 checks passed
AlexanderDokuchaev added a commit to AlexanderDokuchaev/nncf that referenced this pull request Aug 23, 2024
### Changes

Remove "Add release label" step

### Reason for changes

The condition `${{ contains(github.event.pull_request.base.ref,
'release_v') }}` will never be `True`, because this action triggered
only for a pull request to develop branch.

```
on:
  pull_request:
    branches:
      - develop
```

Label `release target` should be added by
openvinotoolkit#2836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants