[Torch] INT4 weight compression #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
alexsu52
force-pushed
the
as/int4_torch_fx
branch
4 times, most recently
from
7906fa8
to
c1d9fd7
Compare
alexsu52
force-pushed
the
as/int4_torch_fx
branch
from
d4df25c
to
b4d13b8
Compare
ljaljushkin
reviewed
Oct 23, 2024
ljaljushkin
reviewed
Oct 23, 2024
| ) | ||
|
|
||
| if backup_mode is not None: | ||
| raise AttributeError("TorchFX backend does not support backup_mode option.") | ||
| if ratio is not None and ratio != 1: |
There was a problem hiding this comment.
As far as I can see, Torch and Torch FX have the same processing of parameters. Does it make sense to combine them in a single function?
There was a problem hiding this comment.
Thanks for this comment. Thanks for this comment. We are going to refactor it when the torch.fx backend will be ready to move out from experiments module.
cc' @daniil-lyakhov, @anzr299
ljaljushkin
reviewed
Oct 23, 2024
alexsu52
force-pushed
the
as/int4_torch_fx
branch
from
a6e4a47
to
2632e99
Compare
ljaljushkin
requested changes
Oct 24, 2024
alexsu52
force-pushed
the
as/int4_torch_fx
branch
from
2632e99
to
9a1432c
Compare
ljaljushkin
approved these changes
Oct 24, 2024
andreyanufr
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
INT4SymmetricWeightsDecompressorandINT4ASymmetricWeightsDecompressorReason for changes
Support INT4 weight model compression of PyTorch models in NNCF.
Related tickets
#3005
Tests
updated tests