Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ignored RoPE for ONNX/PT #3059

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Nov 5, 2024

On top of #3049

Changes

  • As stated in the title.
  • Added Sin and Cos ONNX/PT operations.

Reason for changes

  • Accuracy improvement for models with ModelType.TRANSFORMERS type.

Related tickets

  • 155511

Tests

  • Added graph test for ONNX/PT.

@KodiaqQ KodiaqQ mentioned this pull request Nov 5, 2024
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF ONNX Pull requests that updates NNCF ONNX labels Nov 5, 2024
@KodiaqQ KodiaqQ marked this pull request as ready for review November 6, 2024 07:37
@KodiaqQ KodiaqQ requested a review from a team as a code owner November 6, 2024 07:37
@KodiaqQ KodiaqQ merged commit 80df08b into openvinotoolkit:develop Nov 7, 2024
14 checks passed
nikita-savelyevv pushed a commit to nikita-savelyevv/nncf that referenced this pull request Dec 11, 2024
On top of openvinotoolkit#3049

### Changes

- As stated in the title.
- Added Sin and Cos ONNX/PT operations.

### Reason for changes

- Accuracy improvement for models with ModelType.TRANSFORMERS type.

### Related tickets

- 155511

### Tests

- Added graph test for ONNX/PT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants