[mypy] extend mypy check #3154
Open
[mypy] extend mypy check #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF Common
alexsu52
reviewed
Dec 23, 2024
AlexanderDokuchaev
force-pushed
the
ad/mypy_quant1
branch
3 times, most recently
from
3980c9c to
cbf5bca
Compare
alexsu52
reviewed
Dec 24, 2024
| @@ -232,16 +232,16 @@ class AdvancedQuantizationParameters: | |||
| """ | |||
|
|
|||
| # General parameters | |||
| overflow_fix: OverflowFix = None | |||
| overflow_fix: Optional[OverflowFix] = None | |||
There was a problem hiding this comment.
Please, update type in the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added some files to mypy check and fix errors: