Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E-103104] - Port G-API demos to API2.0 - part 1 #3889

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[E-103104] - Port G-API demos to API2.0 - part 1 #3889

merged 2 commits into from
Dec 27, 2023

Conversation

DariaMityagina
Copy link
Contributor

Tiket:

103104

Description:

G-API Background Subtraction Demo, Classification Benchmark C++ G-API Demo, G-API Gaze Estimation Demo and other - fail on NPU with the following error: dynamic shape issues

get_shape was called on a descriptor::Tensor with dynamic shape
  • OpenVINO is actively removing API 1.0 from their code
  • Both G-API framework and G-API demos use API 1.0 --> which leads to disruption of certain functionality
    Conclusion: We need to port the G-API demos to API2.0 to make them work.

Affected demos:

Passing:

  • classification_benchmark_demo
  • face_detection_mtcnn_demo
  • interactive_face_detection_demo

Related PRs:

Part 2: #3887 - WIP

@DariaMityagina DariaMityagina mentioned this pull request Dec 27, 2023
Draft
6 tasks
@DariaMityagina
Copy link
Contributor Author

DariaMityagina commented Dec 27, 2023 •
edited
Loading

@Maxim-Doronin, @dmatveev, @AsyaPronina hi! Could you please take a look at this PR?

@DariaMityagina DariaMityagina marked this pull request as ready for review December 27, 2023 10:26
dmatveev
dmatveev approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fantastic, thanks!

@DariaMityagina
Copy link
Contributor Author

@Wovchena do you have other comments? Can this PR be merged?

Wovchena
Wovchena approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. I'm going to merge after precommit passes

@DariaMityagina
Copy link
Contributor Author

Ready to be merged. Thank you!

@Wovchena Wovchena merged commit f1f7361 into openvinotoolkit:master Dec 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena approved these changes

@dmatveev dmatveev dmatveev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DariaMityagina @dmatveev @Wovchena