Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Support rope for glm4v #27545

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[GPU] Support rope for glm4v #27545

wants to merge 8 commits into from
+7 −4

Conversation

zhaohb
Copy link
Contributor

@zhaohb zhaohb commented Nov 14, 2024 •
edited by peterchen-intel
Loading

support rope kernel for glm4v

Tickets: CVS-157422

@zhaohb zhaohb requested a review from a team as a code owner November 14, 2024 02:46
@zhaohb zhaohb requested review from itikhono and removed request for a team November 14, 2024 02:46
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Nov 14, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Nov 14, 2024
@zhaohb zhaohb changed the title Support rope for glm4v [GPU] Support rope for glm4v Nov 14, 2024
@zhaohb zhaohb marked this pull request as draft November 14, 2024 02:53
@zhaohb zhaohb marked this pull request as ready for review November 14, 2024 07:15
@sammysun0711
Copy link
Collaborator

@ahnyoung-paul, @isanghao @yeonbok @itikhono, could you please kindly review this PR. Thanks!

zhangYiIntel
zhangYiIntel requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@zhangYiIntel zhangYiIntel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for this new pattern at
src/common/transformations/tests/common_optimizations/fuse_rotary_positional_embeddings.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangYiIntel zhangYiIntel zhangYiIntel requested changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@isanghao isanghao Awaiting requested review from isanghao

@ahnyoung-paul ahnyoung-paul Awaiting requested review from ahnyoung-paul

@yeonbok yeonbok Awaiting requested review from yeonbok

@ceciliapeng2011 ceciliapeng2011 Awaiting requested review from ceciliapeng2011

@riverlijunjie riverlijunjie Awaiting requested review from riverlijunjie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
category: transformations OpenVINO Runtime library - Transformations ExternalPR External contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaohb @sammysun0711 @zhangYiIntel @sys-openvino-ci