Fix keeping ci artifacts (#1389)

.ci/validate_notebooks.py

@@ -17,7 +17,7 @@ def parse_arguments():
     parser.add_argument('--test_list', required=False, nargs='+')
     parser.add_argument('--early_stop', action='store_true')
     parser.add_argument('--report_dir', default='report')
-    parser.add_argument('--clean_artifacts', required=False, default=True)
+    parser.add_argument('--keep_artifacts', action='store_true')
     parser.add_argument('--collect_reports', action='store_true')
     parser.add_argument("--move_notebooks_dir")
     parser.add_argument("--timeout", type=int, default=7200, help="Timeout for running single notebook in seconds")
@@ -86,7 +86,7 @@ def clean_test_artifacts(before_test_files, after_test_files):
             shutil.rmtree(file_path, ignore_errors=True)
 
 
-def run_test(notebook_path, root, timeout=7200, clean_artifacts=True):
+def run_test(notebook_path, root, timeout=7200, keep_artifacts=False):
     os.environ["HUGGINGFACE_HUB_CACHE"] = str(notebook_path)
     print(f'RUN {notebook_path.relative_to(root)}', flush=True)
 
@@ -107,7 +107,7 @@ def run_test(notebook_path, root, timeout=7200, clean_artifacts=True):
         except subprocess.TimeoutExpired:
             retcode = -42
 
-        if clean_artifacts:
+        if not keep_artifacts:
             clean_test_artifacts(existing_files, sorted(Path('.').iterdir()))
     return retcode
 
@@ -157,11 +157,15 @@ def main():
         root = notebooks_moving_dir.parent
         move_notebooks(notebooks_moving_dir)
 
+    keep_artifacts = False
+    if args.keep_artifacts:
+        keep_artifacts = True
+
     test_plan = prepare_test_plan(args.test_list, args.ignore_list, notebooks_moving_dir)
     for notebook, report in test_plan.items():
         if report['status'] == "SKIPPED":
             continue
-        status = run_test(report['path'], root, args.timeout, args.clean_artifacts)
+        status = run_test(report['path'], root, args.timeout, keep_artifacts)
         if status:
             report['status'] = "TIMEOUT" if status == -42 else "FAILED"
         else: