Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 281-photo-maker notebook #1632

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

openvino-dev-samples
Copy link
Collaborator

@openvino-dev-samples openvino-dev-samples commented Jan 20, 2024

add 281-photo-maker notebook

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 3 times, most recently from 77e99dd to 849d3fb Compare January 21, 2024 13:37
@openvino-dev-samples openvino-dev-samples changed the title add 279-photo-maker add 279-photo-maker notebook Jan 21, 2024
@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 5 times, most recently from a414b73 to 49c77d7 Compare January 22, 2024 02:39
@eaidova eaidova requested review from a team, apaniukov, sbalandi and itrushkin and removed request for a team January 22, 2024 09:33
@eaidova eaidova added the new notebook new jupyter notebook label Jan 22, 2024
notebooks/279-photo-maker/279-photo-maker.ipynb Outdated Show resolved Hide resolved
notebooks/279-photo-maker/279-photo-maker.ipynb Outdated Show resolved Hide resolved
notebooks/279-photo-maker/279-photo-maker.ipynb Outdated Show resolved Hide resolved
notebooks/279-photo-maker/279-photo-maker.ipynb Outdated Show resolved Hide resolved
@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 3 times, most recently from 8686b84 to e6bf758 Compare January 22, 2024 15:51
openvino-dev-samples and others added 3 commits January 22, 2024 07:52
fix the ci issue

fix the ci issue

fix the ci issue

fix the reaccording to view suggestion

fix the reaccording to view suggestion

fix the reaccording to view suggestion
* fix vegart syntax error, update stable zephyr

* fix saving fp16 calibrated model on win

update jupyterlab (openvinotoolkit#1635)
@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 3 times, most recently from 355a218 to 4b02640 Compare January 23, 2024 05:59
update the text encoder converter

update the text encoder converter
@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 2 times, most recently from 9d44eee to 31979eb Compare January 23, 2024 15:48
@@ -0,0 +1,1072 @@
{
Copy link
Contributor

@itrushkin itrushkin Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModuleNotFoundError                       Traceback (most recent call last)
Cell In[4], line 6
      4 from PIL import Image
      5 from pathlib import Path
----> 6 from PhotoMaker.photomaker.model import PhotoMakerIDEncoder
      7 from PhotoMaker.photomaker.pipeline import PhotoMakerStableDiffusionXLPipeline
      8 from diffusers import EulerDiscreteScheduler

File ~/repos/openvino_notebooks/notebooks/279-photo-maker/PhotoMaker/photomaker/__init__.py:2
      1 from .model import PhotoMakerIDEncoder
----> 2 from .pipeline import PhotoMakerStableDiffusionXLPipeline
      4 __all__ = [
      5     "PhotoMakerIDEncoder",
      6     "PhotoMakerStableDiffusionXLPipeline",
      7 ]

File ~/repos/openvino_notebooks/notebooks/279-photo-maker/PhotoMaker/photomaker/pipeline.py:8
      5 import numpy as np 
      7 import torch
----> 8 from torchvision import transforms as T
     10 from safetensors import safe_open
     11 from huggingface_hub.utils import validate_hf_hub_args

ModuleNotFoundError: No module named 'torchvision'

Please install PhotoMaker repository requirements


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi I think torchvision has been already installed with default requirement.txt, so no need to reinstall it.

Copy link
Collaborator

@eaidova eaidova Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenVINO-dev-contest current methodology that all dependencies should be installed in notebook for allowing standalone execution (e.g. in google colab), usage common requirements.txt is deprecated

@eaidova
Copy link
Collaborator

eaidova commented Jan 24, 2024

@OpenVINO-dev-contest looks like it is not enough memory for running this notebook in github actions (it has less 10gb RAM), could you please disable its execution in tests?

@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 2 times, most recently from 4b0aa4a to feaa491 Compare January 24, 2024 14:26
@openvino-dev-samples openvino-dev-samples force-pushed the photomaker branch 3 times, most recently from 7b9bcb9 to 11099d5 Compare January 25, 2024 14:38
fix the wrong id
@openvino-dev-samples
Copy link
Collaborator Author

@OpenVINO-dev-contest looks like it is not enough memory for running this notebook in github actions (it has less 10gb RAM), could you please disable its execution in tests?

done

@openvino-dev-samples openvino-dev-samples changed the title add 279-photo-maker notebook add 281-photo-maker notebook Jan 26, 2024
@eaidova eaidova merged commit 4733f83 into openvinotoolkit:main Jan 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new notebook new jupyter notebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants