add OpenVoice #1633
add OpenVoice #1633
Conversation
pavel-esir
commented
Jan 22, 2024
•
pavel-esir
commented
- add OpenVoice notebook
- ticket CVS-130638
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
andrei-kochin
requested review from
a team,
apaniukov,
sbalandi and
aleksandr-mokrov
and removed request for
a team
pavel-esir
force-pushed
the
add_openvoice
branch
from
1169a0d to
05231ab
Compare
pavel-esir
force-pushed
the
add_openvoice
branch
from
956b5f8 to
594d99b
Compare
pavel-esir
force-pushed
the
add_openvoice
branch
from
3ea3c92 to
dc69731
Compare
pavel-esir
force-pushed
the
add_openvoice
branch
from
33a932b to
64d56e6
Compare
|
openvino is still needed to install here. And add -q to all pip install: %pip install -q package View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB aleksandr-mokrov commented on 2024-01-31T11:48:42Z Line #2. demo.close() It is not required anymore pavel-esir commented on 2024-01-31T16:07:27Z done |
|
View / edit / reply to this conversation on ReviewNB aleksandr-mokrov commented on 2024-01-31T11:52:19Z Line #1. %pip install ffmpeg-downloader -q pavel-esir commented on 2024-01-31T16:07:36Z done |
|
done View entire conversation on ReviewNB |
|
done View entire conversation on ReviewNB |
|
done View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB eaidova commented on 2024-02-01T12:38:39Z please add title to notebook pavel-esir commented on 2024-02-02T10:57:20Z done |
|
View / edit / reply to this conversation on ReviewNB eaidova commented on 2024-02-01T12:38:41Z This notebooks provides example of converting original OpenVoice model (https://github.com/myshell-ai/OpenVoice) to OpenVINO IR format for faster inference. -> This notebooks provides example of converting PyTorch OpenVoice model to OpenVINO IR pavel-esir commented on 2024-02-02T10:57:10Z done |
|
View / edit / reply to this conversation on ReviewNB eaidova commented on 2024-02-01T12:38:41Z this comment looks strange in review window, could you please remove when apply todo. Depends from usage inside model, it maybe not a problem to wrap scalar to torch.tensor as example input for tracing only (e.g. if they used only in math operations with tensors (mul, add e.t.c.) pavel-esir commented on 2024-02-02T10:55:59Z Done: when scalars are wrapped as torch.tensor it works fine. Removed todo |
|
View / edit / reply to this conversation on ReviewNB eaidova commented on 2024-02-01T14:01:53Z Line #14. import urllib.request downloading utils file used for making notebook standalone and provide opportunity to run it in isolated environment where there is no access to additional files (e.g. google colab). It is slightly strange that we downloading utils, but in the same time at the end of notebook, we import python module with gradio demo. I recommend to align (download both or use both from repo). Also you can remove both dependencies - move gradio functions into notebook and use hf API for downloading files instead of notebook utils pavel-esir commented on 2024-02-02T10:56:59Z Done. Now no extra utils/py files are needed, notebooks alone is enough |
|
Done: when scalars are wrapped as torch.tensor it works fine. Removed todo View entire conversation on ReviewNB |
|
Done. Now no extra utils/py files are needed, notebooks alone is enough View entire conversation on ReviewNB |
|
done View entire conversation on ReviewNB |
|
done View entire conversation on ReviewNB |
pavel-esir
force-pushed
the
add_openvoice
branch
from
f296278 to
8d934ad
Compare
