Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT8 quantization for "surya" model #1977

Merged
merged 19 commits into from
May 2, 2024

Conversation

as-suvorov
Copy link
Contributor

Ticket: 132425

@as-suvorov as-suvorov requested review from a team, apaniukov and aleksandr-mokrov and removed request for a team April 29, 2024 13:18
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Apr 30, 2024

View / edit / reply to this conversation on ReviewNB

aleksandr-mokrov commented on 2024-04-30T10:01:15Z
----------------------------------------------------------------

Line #5.        predictions = batch_text_detection([image], int8_ov_model_wrapper, processor)

Could you add a selector which model to use, int8 or fp16?


as-suvorov commented on 2024-04-30T15:24:28Z
----------------------------------------------------------------

added

Copy link
Contributor Author

added


View entire conversation on ReviewNB

@as-suvorov as-suvorov requested a review from eaidova April 30, 2024 15:24
Copy link

review-notebook-app bot commented May 1, 2024

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2024-05-01T14:00:44Z
----------------------------------------------------------------

Line #24.            logits = self.ov_model(kwargs)[logits_out]

there is no need to use logits_out = self.ov_model.output(0), you can simplify just using

logits = self.ov_model(kwargs)[0]


@eaidova
Copy link
Collaborator

eaidova commented May 2, 2024

@as-suvorov please fix code style

@eaidova eaidova merged commit 8433f52 into openvinotoolkit:latest May 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants