[DRAFT] ICU build from sources #387
Draft
+629
−675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-normalization # Conflicts: # src/charsmap_normalization.cpp # tests/layer_tests.py
Support UnicodeNormalization and CaseFold operations using new backend. Do not use FastTokenizer dependency during build.
| @@ -314,7 +312,7 @@ jobs: | |||
| # | |||
|
|
|||
| - name: Install build dependencies | |||
| run: brew install coreutils ninja | |||
| run: brew install coreutils ninja icu4c | |||
There was a problem hiding this comment.
I suppose we need to drop icu4c installation
There was a problem hiding this comment.
please, add copyright header to this file
cmake/external/icu.cmake
Outdated
| set(ICU_BUILD_TYPE ${CMAKE_BUILD_TYPE}) | ||
| endif() | ||
|
|
||
| if (CMAKE_BUILD_TYPE STREQUAL "Debug") |
There was a problem hiding this comment.
GENERATOR_IS_MULTI_CONFIG_VAR should be handled here as well
cmake/external/icu.cmake
Outdated
|
|
||
| set(HOST_ENV_CMAKE ${CMAKE_COMMAND} -E env | ||
| CC=${CMAKE_C_COMPILER} | ||
| CXX=${CMAKE_CXX_COMPILER} |
There was a problem hiding this comment.
current issue on macOS is because of we override compilers (tested locally)
maybe we can skip overriding it temporarily? because it's not often situation when compiler on macOS is other than default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.