Assorted fixes 2024/04/28 #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears OK for dynamic_Demangle() to return a pointer to its input string, rather than to a copy, because the only uses are: 1. In dynamic_parser.c, on pointers to config file lines, and we pre-read the entire config file (and includes) into a linked list of separate line structs, and we don't de-allocate those. 2. In dynamic_compiler.c: #define APP_CFUNC(N), we only pass the returned pointer to dyna_helper_appendn(), which does not store the pointer. Mostly fixes openwall#5465 (memory leak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes or works around 3 separate GitHub issues where I had proposed those changes recently. It's passed all GitHub Actions tests in my private fork.