Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Add foundations for proofing/issuance. #465

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

davidz25
Copy link
Contributor

This includes basic types, flows, and three different evidence types as well as an implementation of a self-signed implementation which is implemented entirely in the application. A unit test for the happy flow is also included.

Once this code is baked it will be moved into the identity library.

This commit also includes a small extension to managedAuthenticationKeyHelper() to perform a dry run. This is needed for the application to know how many authentication keys will be created.

Also include a fix to get the identity-android unit tests to compile (we really need to start running these in presubmit).

Test: Manually tested (appholder, appverifier, samples/preconsent-mdl, samples/age-verifier-mdl, wallet, secure-area-test-app)
Test: New unit tests and all unit tests pass (wallet, identity, identity-android).

This includes basic types, flows, and three different evidence types as
well as an implementation of a self-signed implementation which is implemented
entirely in the application. A unit test for the happy flow is also included.

Once this code is baked it will be moved into the identity library.

This commit also includes a small extension to managedAuthenticationKeyHelper()
to perform a dry run. This is needed for the application to know how many
authentication keys will be created.

Also include a fix to get the identity-android unit tests to compile (we
really need to start running these in presubmit).

Test: Manually tested (appholder, appverifier, samples/preconsent-mdl, samples/age-verifier-mdl, wallet, secure-area-test-app)
Test: New unit tests and all unit tests pass (wallet, identity, identity-android).

Signed-off-by: David Zeuthen <[email protected]>
@davidz25 davidz25 requested a review from sorotokin January 31, 2024 20:28
Copy link
Contributor

@sorotokin sorotokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorotokin sorotokin merged commit c43eeb9 into main Jan 31, 2024
5 checks passed
@davidz25 davidz25 deleted the wallet-initial-provisioning branch January 31, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants