Don't Base64.UrlSafe Encode x5c in Request #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorotokin
reviewed
Dec 2, 2024
| @@ -870,7 +870,7 @@ lrW+vvdmRHBgS+ss56uWyYor6W7ah9ygBwYFK4EEACI= | |||
| ) | |||
|
|
|||
| val readerX5c = singleUseReaderKeyCertChain.certificates.map { cert -> | |||
| Base64.from(cert.encodedCertificate.toBase64Url()) | |||
| Base64.from(java.util.Base64.getEncoder().encodeToString(cert.encodedCertificate)) | |||
There was a problem hiding this comment.
We probably should use kotlin.io.encoding.Base64 for consistency.
There was a problem hiding this comment.
Yes, please don't use Java libraries.
Where is it defined how x5c is to be encoded?
Used java.util.Base64.getEncoder() to encode the the x5c instead. Tested manually against java.util.Base64.getDecoder() .decode to ensure decoding doesn't throw error. Signed-off-by: Suzanna Jiwani <[email protected]>
suzannajiwani
force-pushed
the
openid4vp_verifier_x5c_encoding
branch
from
5d5a33c to
fa35cfa
Compare
sorotokin
approved these changes
Dec 3, 2024
suzannajiwani
merged commit a2fa0ed
into
openwallet-foundation-labs:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used java.util.Base64.getEncoder() to encode the
the x5c instead.
Tested manually against java.util.Base64.getDecoder().decode to ensure decoding doesn't throw error.