Groundwork to get issuance work in Koltin Multiplatform. #816
Conversation
| * Configuration for a specific secure area [SecureArea] to use. | ||
| */ | ||
| @CborSerializable | ||
| sealed class SecureAreaConfiguration( |
There was a problem hiding this comment.
Does this limit us to SecureAreas defined in this library? I guess only if you want to use the applyConfiguration() methods, right?
There was a problem hiding this comment.
With current implementation, it does limit us, but we can always define an open-ended variant that would have some basic fields + Map<String, DataItem> as an extension point.
identity/build.gradle.kts
Outdated
| @@ -68,7 +83,26 @@ kotlin { | |||
| } | |||
| } | |||
|
|
|||
| val javasharedMain by creating { | |||
There was a problem hiding this comment.
can we call it javaSharedMain (capital S)?
| @@ -0,0 +1,46 @@ | |||
| package com.android.identity.device | |||
There was a problem hiding this comment.
This file should be called DeviceCheck.android.kt and the iOS one should be called DeviceCheck.ios.kt (not all files in the project currently follow this convention)
| println("Server: $server") | ||
| } | ||
| }, | ||
| content = { Text("Test issuance") } |
There was a problem hiding this comment.
Should we call this WalletServerTest instead of IssuanceTest? I mean, as I understand it we're testing the ability to connect to a wallet server... which includes proving to the wallet server that the client is in good standing
There was a problem hiding this comment.
I am planning to actually finish the issuance path in the test later
| generatedAt = Clock.System.now(), | ||
| androidKeystoreAttestKeyAvailable = true, | ||
| androidKeystoreStrongBoxAvailable = true, | ||
| androidIsEmulator = false |
There was a problem hiding this comment.
Maybe add expect val isEmulator: Boolean to com.android.identity.testapp.Platform and have it be true if on Android emulator or iOS simulator?
|
|
||
| expect fun platformSecureArea(): SecureArea | ||
|
|
||
| expect fun platformKeySetting(clientId: String): CreateKeySettings |
There was a problem hiding this comment.
Why not just add this to the existing Platform.kt file in com.android.identity.testapp package?
| * Generates statements validating device/OS/app integrity. Details of these | ||
| * statements are inherently platform-specific. | ||
| */ | ||
| expect object DeviceCheck { |
There was a problem hiding this comment.
Since this can only be implemented on iOS and Android should we introduce a uiMain sourceSet? That way we avoid a dummy DeviceCheck.jvm.kt file and like also DeviceAttestationJvm.kt...
(I'm already contemplating doing this for other things, see the mp-nfc-engagement branch...)
There was a problem hiding this comment.
Or maybe a better name is mobileOsMain (naming is hard, news at 11)
sorotokin
force-pushed
the
ios-attestation
branch
4 times, most recently
from
431225c to
71841fa
Compare
Signed-off-by: Peter Sorotokin <[email protected]>
sorotokin
force-pushed
the
ios-attestation
branch
from
71841fa to
ad1644c
Compare
Combination of project restructuring and change in protocols that allows US to support iOS wallet app (through Kotlin Multiplatform).
identity-flow(which is our RPC mechanism) to KMPidentity-issuanceintoidentity-issuance-apiso our wallet server RPC interface is available in KMPidentityproject as abstraction level that allows us to express attestations/assertions in cross-platform waysample.testappNote: this tweaks the wallet server protocol in incompatible way.
Another note: iOS attestations/assertions are generated and sent to the server, but not yet validated.
Manually tested.