-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the duplicated root issue. #830
base: main
Are you sure you want to change the base?
Fix the duplicated root issue. #830
Conversation
Remove the redundant project dependency, triggering the "Duplicate content roots" automatic deletion action for the generated commonMain/resources folder. Signed-off-by: koukarine <[email protected]>
I tried the same fix back in #767, and it ended up breaking the build, even though tests passed locally (see https://github.com/openwallet-foundation-labs/identity-credential/actions/runs/11620001708/job/32360863428?pr=767). It looks like this PR made it past that step. Any idea why it would build successfully now but wasn't back in October/November? Is there a risk that the build would become flaky with this change? |
It could be explained by a positive change in the project structure, or improvements in the content generating algorithm. The flakiness is usually created by ignoring that error and caused by different paths of possible code building (ambiguity). In this case it should be consistently failing due to the missing resource. We can keep an eye on that for now and if resurfaced or exhibit flakiness then revert it again. Looking through your past build log. |
@kdeus. In your past PR logs I see some other warnings about missing files for the project (at the very beginning). These XML files might be required to generate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like some random flakiness in the old build. I'm not sure what we've changed that would have addressed that, but in any case, it looks like this is the right fix and I just got unlucky. This LGTM. I'll approve.
And I'll leave this unmerged for now, in case you want to do some more investigation. Or feel free to merge whenever.
Remove the redundant project dependency, triggering the "Duplicate content roots" automatic deletion action for the generated commonMain/resources folder.
Fixes #829