feat: Change network status check feature in NetInfo, disable/enable mediator check and provide new method to check isInternetReachable #1390
Conversation
…ing mediator for network check or not Signed-off-by: Jian Wang <[email protected]>
Signed-off-by: Jian Wang <[email protected]>
…e the 'isConnected' control Signed-off-by: Jian Wang <[email protected]>
Signed-off-by: Jian Wang <[email protected]>
|
Will fix the __test, new provider spy failed in other feature testing suites |
Signed-off-by: Jian Wang <[email protected]>
Signed-off-by: Jian Wang <[email protected]>
|
Native Build & Test / build-ios failed, it is the boost installing error happens in the new year. The reason is the host changed - "The boost download was hosted on JFrog until December 31, 2024 when the service ended. Therefore the problem appeared out of nowhere" on Jan 1, 2025". |
…isableFirewallCheck not assert. But skip mediator connecting when it is disabled and check isInternetReachable instead Signed-off-by: Jian Wang <[email protected]>
…internet testing beacons, the networkProvider provides isInternetReachable API according to connecting to 'internetReachabilityUrls' Signed-off-by: Jian Wang <[email protected]>
jian4on
changed the title
jian4on
changed the title
Signed-off-by: Jian Wang <[email protected]>
| return isConnected | ||
| } | ||
|
|
||
| const assertNetworkReachable = async (): Promise<boolean> => { | ||
| // Ping internet check beacon endponits, set internetReachable to be true positive response from anyone |
There was a problem hiding this comment.
Should use the netinfo and not custom code for the reachability check. We can pass custom URLs to the netinfo library if required. The reason for this is that Android has built in reachability checks that netinfo will use if available. The use of google is a fallback. On IOS the netinfo library does use the fallback for now. @jian4on
…, and back using built-in 'isInternetReachable', the custom beakons ping is commented Signed-off-by: Jian Wang <[email protected]>
… not asserted and clear the Toast message once internetReachableCheck passed Signed-off-by: Jian Wang <[email protected]>
Signed-off-by: Jian Wang <[email protected]>
|
Context for this PR: When using the oid4vci flow, a mediator is not necessary. If a mediator is not present (or not needed for the wallet to function in a use case) then there needs to be another way to confirm Internet connectivity. The library react-native-netinfo is already used in the code base and is able to make use of IOS and Android functionality to test Internet reachability with lots of configurability. The other option was to create another .env variable with alternate sites to test that would be used by the existing code instead of the mediator. The assumption is that the native reachability functionality in the OS will scale better then a custom solution. Netinfo also has many small optimizations for corner cases and is well maintained. There is still some overlap in functionality that could be consolidated. A cleaner approach in the future would be to use netinfo events to manage Internet reachability as well as specifically checking for the mediator (if configured). Note that even if the mediator is configured, a wallet may still want to exclude or manage the check differently if the mediator is not part core use case. |
|
@jian4on Please reviews comments so we can proceed. |
Signed-off-by: Jian Wang <[email protected]>
|
Summary of Changes
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓