-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anoncred support #759
Add anoncred support #759
Conversation
5e1451c
to
0a56681
Compare
Signed-off-by: jamshale <[email protected]>
0a56681
to
2fedc3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I had to do a rebuild to get the -t @anoncreds
to be recognized (probably expected…), but once I did that, the proper tests were executed and succeeded.
Note that there are other ways to set the wallet-type on an agent besides the EXTRA args. One is to use an ACA-Py config file that contains startup parameters. The other is in a feature file, as seen in the draft PR #760 where we add start_parameters to the |
I think we generally want to set the wallet type globally. I.e. run me all the tests with aca-py askar wallet, or askar-anoncreds wallet. I don't see the value in setting this in a feature file where we set this on a per-test basis. |
Note that the |
Yes, I agree, generally. It depends on if we want these tests to run in existing runsets or have them separate. All I've done here is open up the start parameters to be fully added to the features file data. It only worked with Transport Protocols previously, and instead of just adding the did peer flags, I opened it all up. We are adding the Right now, this PR, checks for wallet type in the EXTRA Args environment variable to set the handling for AnonCreds, I think it also should check if the tag |
Agree regarding the |
This allows the
askar-anoncreds
wallet and endpoints to be tested in the test harness by running the commandBACKCHANNEL_EXTRA_acapy_main="{\"wallet-type\":\"askar-anoncreds\"}" ./manage run -d acapy-main -t @Anoncreds
v1
tests are still not passing. I figure if they should then another ticket could build off of this. Along with any other tests we feel are important to work with anoncreds.Some imports and formatting was changed due to my ruff formatting extension. Not sure if anyone cares.
Note: This was based off of my acapy fork which includes the recent anoncred endpoint changes. They have been merged to acapy but for some reason acapy main wasn't getting updated with the latest code for me when I was developing.