Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocols and handlers #92

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Protocols and handlers #92

wants to merge 12 commits into from

Conversation

lohuza
Copy link

@lohuza lohuza commented Jan 16, 2023

No description provided.

chumaknadya
chumaknadya reviewed Jan 18, 2023
View reviewed changes
nats/store.go Outdated
Delete(key string) error
}

type bucketManager struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make it exportable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it thought? we have interface BucketManager

@lohuza lohuza self-assigned this Jan 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chumaknadya chumaknadya chumaknadya left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lohuza lohuza

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lohuza @chumaknadya