Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a special case to feedback to show correct answers only. #1065

Merged

Conversation

drgrice1
Copy link
Member

If the translation options showCorrectAnswers,
forceShowAttemptResults, and forceScaffoldsOpen are all true, and the options showAttemptAnswers, showAttemptPreviews, and showMessages are all false, then correct answers will be shown with no other content in the feedback popover except a close button. Furthermore the popover will open automatically on page load. Obviously scaffold will all be open (since the forceScaffoldsOpen option is true). Otherwise there would be a problem with popovers opening immediately from inside a closed scaffold.

A corresponding pull request to webwork2 will utilize this.

This is a potential approach to resolve #1047.

@drgrice1 drgrice1 force-pushed the feedback-show-correct-only branch 6 times, most recently from 96c9cd8 to fa7e133 Compare April 26, 2024 13:08
@drgrice1 drgrice1 changed the base branch from develop to PG-2.19 May 1, 2024 20:58
Copy link
Member

@drdrew42 drdrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a lot of different problems. This looks good.

If the translation options `showCorrectAnswers`,
`forceShowAttemptResults`, and `forceScaffoldsOpen` are all true, and
the options `showAttemptAnswers`, `showAttemptPreviews`, and
`showMessages` are all false, then correct answers will be shown with no
other content in the feedback popover except a close button.
Furthermore the popover will open automatically on page load. Obviously
scaffold will all be open (since the `forceScaffoldsOpen` option is
true).  Otherwise there would be a problem with popovers opening
immediately from inside a closed scaffold.

A corresponding pull request to webwork2 will utilize this.
@drgrice1 drgrice1 force-pushed the feedback-show-correct-only branch from 4eb46e2 to 9176e9a Compare May 17, 2024 13:32
@Alex-Jordan Alex-Jordan merged commit d3a483e into openwebwork:PG-2.19 May 31, 2024
3 checks passed
drgrice1 pushed a commit that referenced this pull request May 31, 2024
Add a special case to feedback to show correct answers only.
@drgrice1 drgrice1 deleted the feedback-show-correct-only branch June 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants