Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the a trig functions to the mqeditor autoCommands. #1071

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

drgrice1
Copy link
Sponsor Member

This depends on openwebwork/mathquill#29. This temporarily has switched the version of MathQuill in the package.json file to the branch for that pull request. That is why this is being created as a draft pull request and should not be merged until that is removed. This is for ease of testing. When you run npm ci it will install the MathQuill from that branch.

@drgrice1
Copy link
Sponsor Member Author

Note that you can also test the other things that were recently merged into MathQuill with this branch. Of course you can also test those with #1067.

@drgrice1 drgrice1 changed the base branch from develop to PG-2.19 May 1, 2024 20:58
@pstaabp
Copy link
Sponsor Member

pstaabp commented May 15, 2024

Seems to work and I think for the inverse trig functions, this seems like a good way to handle asin, acos, ...

Copy link
Contributor

@Alex-Jordan Alex-Jordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This together with openwebwork/mathquill#29 works for me.

@drgrice1 drgrice1 marked this pull request as ready for review July 9, 2024 18:26
@pstaabp pstaabp merged commit 8f8aa9f into openwebwork:PG-2.19 Jul 9, 2024
3 checks passed
@drgrice1 drgrice1 deleted the mathquill-add-a-trig branch July 9, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants