-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add previous answers to MathQuill inputs on the next tick. #1072
Add previous answers to MathQuill inputs on the next tick. #1072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the strange behavior.
f5bdd0f
to
e96920f
Compare
e96920f
to
ea4f8b4
Compare
ea4f8b4
to
eb34183
Compare
eb34183
to
d43bed0
Compare
d43bed0
to
288c661
Compare
I checked out a copy of PG-2.19 branch and merged this branch into it. Then I ran |
Experimenting with this more I see that sometimes it happens, and sometimes it doesn't. I increased the delay before the timeout executes to a tenth of a second. I haven't been able to reproduce it with that yet. However, it might still happen anyway. I don't really think this pull request should be merged. I think more investigation is needed to determine what is really going on. I also don't think this is particularly high priority though. I think typing |
OK, FWIW, I pulled with the 100ms delay, and now I am not seeing the issue. And no, this is not high priority. IIRC I was trying things that might demonstrate an insertion vulnerability and that exposed this. But no reasonable exercise would lead to a user inputting this kind of answer. |
…position-update Update feedback popover position when typing in a MathQuill input.
This fixes openwebwork/mathquill#30. Although, I am not sure what is going on here. For some reason delaying filling in previous answers until the "next tick" (a timeout with 0 delay) fixes the problem. Probably the MathQuill math field is not fully initialized until after the mqeditor setup method completes. I am unable to reproduce the issue using the development build of MathQuill directly via `npm run serve`.
This seems to help some.
8243a87
to
452128f
Compare
Merging this for now. Maybe there's a better solution to find later. |
…xt-tick Add previous answers to MathQuill inputs on the next tick.
This fixes openwebwork/mathquill#30. Although, I am not sure what is going on here. For some reason delaying filling in previous answers until the "next tick" (a timeout with 0 delay) fixes the problem. Probably the MathQuill math field is not fully initialized until after the mqeditor setup method completes.
I am unable to reproduce the issue using the development build of MathQuill directly via
npm run serve
.