allow characters for lte and gte in a few contexts #1099
Conversation
| string => ' <= ', | ||
| TeX => '\le ', | ||
| kind => "le", | ||
| alternatives => [ '=<', "\x{2264}" ], |
There was a problem hiding this comment.
I'm confused by the alternatives, as the first one is the same as the actual operator at line 10. Was this meant to go in the previous operator <=?
One could make =< an alias for => rather than an alternative. I think that might not have been available for operators when this was written.
There was a problem hiding this comment.
Wait, I'm looking at this again and I think it is right. Maybe the diff is misleading.
This removes =< as an operator altogether. And then it makes =< and "\x{2264}" be alternatives for <=. Because the original block for <= and =< are right next to each other and nearly identical, the diff that is displayed might be misleading.
There was a problem hiding this comment.
My fault, I misread the diffs (argh!).
Note, however, that making =< and >= alternatives means they will not be defined by default (as parseAlternatives is false by default. So that changes the definition of the setup for this context. That is why I was suggesting making =< and >= be aliases rather than alternatives, but if you want them removed, you should make that explicit, and in that case you need to change the documentation as well.
There was a problem hiding this comment.
OK, I didn't think about how alternatives are not available by default. I was thinking I was just simplifying the code, but of course you are right that it would change behavior. I updated the commit to only add the ≤ and ≥ alternatives. (And ≠ in the other file where != has meaning.)
| TeX => '\ge ', | ||
| kind => 'ge', | ||
| reverse => 'le', | ||
| alternatives => [ '=>', "\x{2265}" ], |
|
Yeah, sorry. I was manually copy-pasting from where I have this in my production server and messed that up. I'll fix it soon. |
This is so a student can directly enter ≤ and ≥ in contexts where
<=and>=are valid operators.It affects a bit more than just the two files here, because at least one context (Inequality-SetBuilder) is built on top of
contextInequalities.pl.