Add an en-GB localization file. #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't exactly needed, but is added for consistency. As for webwork2, translation isn't really needed in the `.po` file. However, if someone wants to do so it could be done. Note that the `en.po` file was updated as well. This file hasn't been updated for a while since it really doesn't need to be.
drgrice1
force-pushed
the
en-GB-localization
branch
from
60e281e
to
8584184
Compare
somiaj
approved these changes
Sep 3, 2024
|
Yeah, this is just for completeness. Also, I think it would be an error if the file did not exist and the language was selected when a problem renders. |
|
I did test a few problems and got no errors, so that at least is good. |
|
FWIW, it seems using |
|
If anyone else is testing this, you also need to checkout openwebwork/webwork2#2553 |
pstaabp
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't exactly needed, but is added for consistency. As for webwork2, translation isn't really needed in the
.pofile. However, if someone wants to do so it could be done.Note that the
en.pofile was updated as well. This file hasn't been updated for a while since it really doesn't need to be.