Use @openwebwork/mathquill from npm instead of directly using github.
#1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
mathquill-npm
branch
from
c44484e
to
77c6fb6
Compare
|
I had to do a |
|
Generally anytime anything in the |
drgrice1
force-pushed
the
mathquill-npm
branch
from
77c6fb6
to
39a0b25
Compare
pstaabp
approved these changes
Sep 17, 2024
A beta version of an `@openwebwork/mathquill` package has been published on npm. This switches to using that instead of from github. The github repository will also be updated to not include the distribution build anymore. This fixes the mess of always needing to reubild the `dist` files for every change to the mathquill code. That is a real pain when different pull requests are made, particularly unrelated pull requests, as they have to be put in order with sequential builds.
drgrice1
force-pushed
the
mathquill-npm
branch
from
39a0b25
to
d5db819
Compare
somiaj
approved these changes
Oct 1, 2024
|
Two approvals so I'll merge. Works in my testing in both using MathQuill and past answers. |
|
Since this is merged, openwebwork/mathquill#32 should also be reviewed and merged since this technically depends on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A beta version of an
@openwebwork/mathquillpackage has been published on npm. This switches to using that instead of from github. Before the next release, a non-beta version will be published and this updated to use that version.The github repository will also be updated to not include the distribution build anymore. This fixes the mess of always needing to reubild the
distfiles for every change to the mathquill code. That is a real pain when different pull requests are made, particularly unrelated pull requests, as they have to be put in order with sequential builds.