Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent extra p surrounding multiple choice ul in PTX #1118

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Alex-Jordan
Copy link
Contributor

This should have been included in #1090.

Without getting into the weeds too much, consider something like:

$rational = DropDown(["is","is not",], 1);

BEGIN_PGML
The number [`\sqrt{2}`] [_]{$rational}{5} rational.

Without this commit, the PTX output is like:

<p>The number <m>\sqrt{2}</m> <p><ul form="popup" ...> ...

Note the p within a p.

With this commit, the PTX output is:

<p>The number <m>\sqrt{2}</m> <ul form="popup" ...> ...

Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the additional regex matches your description, but again don't have a way to test.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@drgrice1 drgrice1 merged commit 4578bbc into openwebwork:develop Sep 17, 2024
3 checks passed
drgrice1 added a commit that referenced this pull request Sep 17, 2024
prevent extra p surrounding multiple choice ul in PTX (hotfix for #1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants