PTX: when removing unwanted p in a cell, consider that the cell may h… #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Sep 16, 2024
drgrice1
approved these changes
Sep 17, 2024
drgrice1
added a commit
that referenced
this pull request
Sep 17, 2024
PTX: when removing unwanted p in a cell... (hotfix of #1120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ave attributes
The regex in this line is pretty dense. What this block tries to do is described in the comment above this line. This regex does not literally do that, but it is close. To really do what the comment describes would require a lot of work.
In the meantime, there was a small flaw with the regex that this fixes. There is a place in the regex looking for a
celltag, and the assumption was it would be like<cell>. But it might be like<cell bottom="minor">or something like that with attributes. The change makes it matches those situations too.